Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSPS-402 Update Teaspoons success notification to use userDataTtlDays param #375

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

jsotobroad
Copy link
Contributor

@jsotobroad jsotobroad commented Jan 30, 2025

Jira: https://broadworkbench.atlassian.net/browse/TSPS-402

What:

This pr is following up changes made to workbench-libs in broadinstitute/workbench-libs#1720 and broadinstitute/workbench-libs#1721 that will grab a userDataTtlDays value from the notification message and use it to populate our notification.

Why:

We want to have this data available when creating our notification so we can inform our users how long they have before their inputs/outputs will be deleted

How:

We pull in the new workbench libs notifications library that was published in the PRs linked above and then pass in the new value to the teaspoons success notification.


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@jsotobroad jsotobroad requested a review from a team as a code owner January 30, 2025 19:49
@jsotobroad jsotobroad requested review from davidangb and kevinmarete and removed request for a team January 30, 2025 19:49
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.69%. Comparing base (a1a20b4) to head (156e478).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ala/thurloe/notification/NotificationMonitor.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #375      +/-   ##
===========================================
- Coverage    56.78%   56.69%   -0.09%     
===========================================
  Files           18       18              
  Lines          671      672       +1     
  Branches        76       77       +1     
===========================================
  Hits           381      381              
- Misses         290      291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kevinmarete kevinmarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the codecov report this looks good to me.

@jsotobroad jsotobroad merged commit 528b84e into develop Jan 31, 2025
7 of 9 checks passed
@jsotobroad jsotobroad deleted the js_TSPS-402 branch January 31, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants