[16.0][IMP] sale order carrier auto assign multi-company #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 16.0-imp-sale_order_carrier_auto_assign-add-config #34 +/- ##
=====================================================================================
Coverage ? 93.67%
=====================================================================================
Files ? 532
Lines ? 9321
Branches ? 1087
=====================================================================================
Hits ? 8731
Misses ? 387
Partials ? 203 ☔ View full report in Codecov by Sentry. |
jbaudoux
requested changes
Feb 21, 2024
|
Hi @jbaudoux, thank you for comment. I took into account your remarks. |
jbaudoux
approved these changes
Feb 22, 2024
jbaudoux
reviewed
Feb 22, 2024
Comment on lines
73
to
+75
| * Phuc (Tran Thanh) <[email protected]> | ||
| * Telmo Santos <[email protected]> | ||
| * Tris Doan <[email protected]> |
There was a problem hiding this comment.
Can you drop changes to README in the PR?
Comment on lines
-382
to
+387
| <li><a class="reference internal" href="#bug-tracker" id="toc-entry-1">Bug Tracker</a></li> | ||
| <li><a class="reference internal" href="#credits" id="toc-entry-2">Credits</a><ul> | ||
| <li><a class="reference internal" href="#authors" id="toc-entry-3">Authors</a></li> | ||
| <li><a class="reference internal" href="#contributors" id="toc-entry-4">Contributors</a></li> | ||
| <li><a class="reference internal" href="#maintainers" id="toc-entry-5">Maintainers</a></li> | ||
| <li><a class="reference internal" href="#configuration" id="toc-entry-1">Configuration</a></li> | ||
| <li><a class="reference internal" href="#bug-tracker" id="toc-entry-2">Bug Tracker</a></li> | ||
| <li><a class="reference internal" href="#credits" id="toc-entry-3">Credits</a><ul> | ||
| <li><a class="reference internal" href="#authors" id="toc-entry-4">Authors</a></li> | ||
| <li><a class="reference internal" href="#contributors" id="toc-entry-5">Contributors</a></li> | ||
| <li><a class="reference internal" href="#maintainers" id="toc-entry-6">Maintainers</a></li> |
There was a problem hiding this comment.
Can you drop changes to index in the PR ?
Comment on lines
3
to
+5
| * Phuc (Tran Thanh) <[email protected]> | ||
| * Telmo Santos <[email protected]> | ||
| * Tris Doan <[email protected]> |
There was a problem hiding this comment.
Just to prevent a conflict with other PR
Suggested change
| * Phuc (Tran Thanh) <[email protected]> | |
| * Telmo Santos <[email protected]> | |
| * Tris Doan <[email protected]> | |
| * Tris Doan <[email protected]> | |
| * Phuc (Tran Thanh) <[email protected]> |
|
superseded by OCA#2976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSALLO-738