Event hub java docs #1658
Event hub java docs #1658
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Spelling Mistakes
- java/messaging.md:291:7 Unknown word "asynchronuos"
- java/messaging.md:291:34 Unknown word "usign"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
| # unique identifier for this event broker instance | ||
| # should start with own namespace (i.e., "foo.bar") and may not be longer than 15 characters | ||
| systemNamespace: cap.service | ||
| webhookUrl: ~{srv-api/srv-cert-url}/messaging/v1.0/eb |
There was a problem hiding this comment.
We cannot assume that the `srv-cert-url´ property is always available in a given customer mta. They would have to additionally bind the corresponding route in their CAP Java backend.
There was a problem hiding this comment.
@BraunMatthias : What do you think if we create a dedicated section how to configure the app with a .cert in a central place? We have some sort of half ready documentation already spread across SMS and IAS. But no central one which we can simple link from locations like this here.
| config: | ||
| # unique identifier for this event broker instance | ||
| # should start with own namespace (i.e., "foo.bar") and may not be longer than 15 characters | ||
| systemNamespace: cap.service |
There was a problem hiding this comment.
This doesn´t match the docs from EventHub I guess. Doesn´t this need to be ceSource? https://help.sap.com/docs/sap-cloud-application-event-hub/sap-cloud-application-event-hub-stakeholder-guide/create-service-instance-for-sap-cloud-applications and search for "single tenancy". The system namespace pops up here magically. We need to provide some information where to get this information.
| messaging.services: | ||
| - name: "eventhub-messaging" | ||
| kind: "event-hub" | ||
| binding: "event-broker" |
There was a problem hiding this comment.
this matches the name of the service binding, right? I would avoid mixing "event-hub" and "event-broker" in the configuration. Maybe "event-hub-binding" produces less confusion
| kind: "enterprise-messaging" | ||
| ``` | ||
| ::: | ||
|
|
||
|
|
||
| #### Configuring SAP Cloud Application Event Hub Support: <Beta/> { #configuring-sap-event-hub-support} |
There was a problem hiding this comment.
With this chapter, the page is getting pretty long. What about moving out the section "Supported Message Brokers" into a dedicated subpage?
| messaging.services: | ||
| - name: "eventhub-messaging" | ||
| kind: "event-hub" | ||
| binding: "event-broker" |
There was a problem hiding this comment.
| binding: "event-broker" | |
| binding: "<event-hub-binding>" |
No description provided.