Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event hub java docs #1658
base: main
Are you sure you want to change the base?
Event hub java docs #1658
Changes from all commits
2054bb8
c3a7ef4
b63687a
afd0974
31ee603
d67d61c
fbd37f8
d14f166
74bbaca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this chapter, the page is getting pretty long. What about moving out the section "Supported Message Brokers" into a dedicated subpage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this matches the name of the service binding, right? I would avoid mixing "event-hub" and "event-broker" in the configuration. Maybe "event-hub-binding" produces less confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn´t match the docs from EventHub I guess. Doesn´t this need to be
ceSource
? https://help.sap.com/docs/sap-cloud-application-event-hub/sap-cloud-application-event-hub-stakeholder-guide/create-service-instance-for-sap-cloud-applications and search for "single tenancy". The system namespace pops up here magically. We need to provide some information where to get this information.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot assume that the `srv-cert-url´ property is always available in a given customer mta. They would have to additionally bind the corresponding route in their CAP Java backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BraunMatthias : What do you think if we create a dedicated section how to configure the app with a
.cert
in a central place? We have some sort of half ready documentation already spread across SMS and IAS. But no central one which we can simple link from locations like this here.