Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status bar custom background #173

Closed
wants to merge 1 commit into from

Conversation

vdbe
Copy link
Contributor

@vdbe vdbe commented Mar 24, 2024

No description provided.

@vdbe
Copy link
Contributor Author

vdbe commented Mar 24, 2024

Some text/icon used thm_bg as foreground.
Maybe it's a better solution to add local color_bg=$5/local color_text=$5 instead of reusing the status background.
We can default to $status_background to avoid breaking changes

image

@vdbe vdbe requested a review from 89iuv March 24, 2024 11:00
@vdbe
Copy link
Contributor Author

vdbe commented Mar 24, 2024

@Gaurav-Gosain What do you think?

@Gaurav-Gosain
Copy link

@vdbe thank you so much for this, I will test it out, but just having a quick glance, it looks like a good solution to the problem!

@89iuv
Copy link
Collaborator

89iuv commented Mar 24, 2024

I am getting this result:
image

I am using:

set -g @catppuccin_status_background "red"

This changes only the status background leaving the other part of tmux unchanged.

@vdbe
Copy link
Contributor Author

vdbe commented Mar 24, 2024

#170 only changed the status bar color, not colors that matched the status-bar by using $thm_bg as background (or foreground in some cases)

With the config

# set -g @catppuccin_status_background "#ff0000"
set -g @catppuccin_status_background "red"

I get

  • Main
    image
  • This branch
    image

@89iuv
Copy link
Collaborator

89iuv commented Mar 24, 2024

I understand the issue now.

There is a disconnect between the status color which is red and the separator background which is $thm_bg.

It would be better to somehow make that part transparent so that it blends into the background, but until then the proposed solution also works.

@vdbe
Copy link
Contributor Author

vdbe commented Mar 24, 2024

It's not just the build_status_module build_window_format has the same issue.
Also just replace thm_bg with status_background for now?

@Gaurav-Gosain
Copy link

So I managed to get it working for my local setup by doing the following:

image

I use catppuccin-mocha so I modified ~/.tmux/plugins/tmux/catppuccin-mocha.tmuxtheme and set the thm_bg variable to default.

thm_bg="default"

This gets most of the job done and should be plenty for most. However after doing this, the background of the icons changed to a light gray which didn't look good with my setup so I went ahead and modified the fg for show_icon to use $thm_gray instead of $thm_bg.

@vdbe vdbe changed the title fix: status background for modules status bar custom background Mar 24, 2024
@vdbe
Copy link
Contributor Author

vdbe commented Mar 28, 2024

Replaced by #175

@vdbe vdbe closed this Mar 28, 2024
@vdbe vdbe deleted the fix/modules-status-bg branch May 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants