-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve transparent background #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only tested example configs.
Config 2 breaks with this change
It does however use set -g @catppuccin_status_connect_separator "no"
With set -g @catppuccin_status_connect_separator "yes"
With set -g @catppuccin_status_connect_separator "no"
Current main (set -g @catppuccin_status_connect_separator "no
)
I guess this replaces #174 ?
Yes, i think this should replace #173. |
Run into a problem here: The objective of the option This creates the situation where we need to choose between having this option or having a transparent background. My proposal is to remove this option as i do not think it is very popular and by doing this we can fully support having a transparent background (requested multiple times) without any other issue. @vdbe what do you think? Edit1. |
Removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating the example configs
- Replace config 2?
- Remove
catppuccin_status_right_separator_inverse
from config 3
Good catch. I forgot about updating the config example. Will work on this next. |
This PR improves the handling of the background color and transparency.
In order for this to work the fallowing setting had to be extended to windows settings:
Note:
Example:
Solid:
Transparent:
Todo: