Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve transparent background #175

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

89iuv
Copy link
Collaborator

@89iuv 89iuv commented Mar 27, 2024

This PR improves the handling of the background color and transparency.

In order for this to work the fallowing setting had to be extended to windows settings:

set -g @catppuccin_status_connect_separator "yes"

Note:

  • you need to restart the tmux server in order for the new background settings to take effect.

Example:
Solid:
image

Transparent:
image

Todo:

  • test this on other configs

@89iuv 89iuv requested a review from vdbe March 27, 2024 19:24
Copy link
Contributor

@vdbe vdbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tested example configs.

Config 2 breaks with this change
It does however use set -g @catppuccin_status_connect_separator "no"

With set -g @catppuccin_status_connect_separator "yes"
image

With set -g @catppuccin_status_connect_separator "no"
image

Current main (set -g @catppuccin_status_connect_separator "no)
image

I guess this replaces #174 ?

@89iuv
Copy link
Collaborator Author

89iuv commented Mar 28, 2024

@vdbe Good find with config 2. I have some ideas on how to fix that one.

I guess this replaces #174 ?

This PR is not related to #174. I think we should merge #174 and announce the breaking change as a pinned issue.

@vdbe
Copy link
Contributor

vdbe commented Mar 28, 2024

This PR is not related to #174. I think we should merge #174 and announce the breaking change as a pinned issue.

Sorry meant #173

@89iuv
Copy link
Collaborator Author

89iuv commented Mar 28, 2024

Yes, i think this should replace #173.

@89iuv
Copy link
Collaborator Author

89iuv commented Mar 28, 2024

Run into a problem here:

The objective of the option @catppuccin_status_right_separator_inverse is to swap between the foreground and the background color for the status right separator.
The problem is that while the background color can be set to transparent, the foreground color defaults to white.

This creates the situation where we need to choose between having this option or having a transparent background.

My proposal is to remove this option as i do not think it is very popular and by doing this we can fully support having a transparent background (requested multiple times) without any other issue.

@vdbe what do you think?

Edit1.
Another solution here would be to support this option only for non transparent backgrounds.

Edit2.
Implemented solution from Edit1.
Background
Solid:
image

Transparent (does not work):
image

@vdbe
Copy link
Contributor

vdbe commented Mar 28, 2024

Removing @catppuccin_status_right_separator_inverse does seem like the best option

@89iuv 89iuv requested a review from vdbe March 28, 2024 14:44
Copy link
Contributor

@vdbe vdbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the example configs

  • Replace config 2?
  • Remove catppuccin_status_right_separator_inverse from config 3

@89iuv
Copy link
Collaborator Author

89iuv commented Mar 28, 2024

Good catch. I forgot about updating the config example. Will work on this next.

catppuccin.tmux Show resolved Hide resolved
@89iuv 89iuv merged commit a107994 into main Mar 28, 2024
3 checks passed
@89iuv 89iuv deleted the improve-transparent-background branch March 28, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants