-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed unnecessary import of check_filename_prefix_postfix #330
base: master
Are you sure you want to change the base?
Conversation
Comment on 618a299. Shortlog of the HEAD commit contains 85 character(s). This is 35 character(s) longer than the limit (85 > 50). Origin: GitCommitBear, Section: |
Comment on 618a299. Shortlog of HEAD commit isn't in imperative mood! Bad words are 'removed' Origin: GitCommitBear, Section: |
Travis tests have failedHey @Manas-kashyap, 1st Buildpytest
TravisBuddy Request Identifier: 989a20c0-e8e6-11e8-a21b-edb6b5ef4ae4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commit message. You should follow the coala commit guidelines.
IMHO this issue was assigned to @thenotsodarkknight. You should avoid working on issue until you have been assigned to it.
Please read https://coala.io/newcomer to see how you should find suitable issues to work on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
- The issue wasn't assigned to you, yet. You should wait for it to get assigned. Ping people on Gitter if it is taking time.
- You haven't followed the Newcomer's Guide.
- The title should be changed as per the guide. It should be in the imperative mood.
Removed
is a bad word. Check the guide. - There's a shortlog of Head Commit. Please refer to Commit Guidelines.
- None of the CI is passing. Please make the CI green and gitmate happy.
I would highly recommend you to go through the Newcomer's Guide. if haven't already.
@@ -11,9 +11,6 @@ | |||
initialize_project_data, | |||
run_quickstartbear, | |||
) | |||
from coala_quickstart.green_mode.filename_operations import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the issue was about removing this import. This is what the issue says 👇
coala_quickstart/green_mode/green_mode_core.py :: green_mode contains a delayed import of check_filename_prefix_postfix which should be removed as it shadows an identical import in the module scope.
the keyword here is delayed, you need to delete just the delayed import if you delete the first import then we won't be able to call this function on this line
Please make the correct changes @Manas-kashyap and if you don't understand the issue don't hesitate to ask us before submitting a PR 😉
removed unnecessary import of check_filename_prefix_postfix leading to resolving of bug number #300