Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unnecessary import of check_filename_prefix_postfix #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removed unnecessary import of check_filename_prefix_postfix #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions coala_quickstart/green_mode/green_mode_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
initialize_project_data,
run_quickstartbear,
)
from coala_quickstart.green_mode.filename_operations import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the issue was about removing this import. This is what the issue says 👇

coala_quickstart/green_mode/green_mode_core.py :: green_mode contains a delayed import of check_filename_prefix_postfix which should be removed as it shadows an identical import in the module scope.

the keyword here is delayed, you need to delete just the delayed import if you delete the first import then we won't be able to call this function on this line

Please make the correct changes @Manas-kashyap and if you don't understand the issue don't hesitate to ask us before submitting a PR 😉

check_filename_prefix_postfix,
)

PROJECT_DATA = '.project_data.yaml'

Expand Down Expand Up @@ -50,8 +47,6 @@ def green_mode(project_dir: str, ignore_globs, bears, bear_settings_obj,
The maximum number of values to run the bear again and again for
a optional setting.
"""
from coala_quickstart.green_mode.filename_operations import (
check_filename_prefix_postfix)
ignore_globs.append(os.path.join(project_dir, '.git', '**'))
project_data = project_dir + os.sep + PROJECT_DATA

Expand Down