chore: add dylib downloader and validator #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
commented
Jan 7, 2025
spikecurtis
reviewed
Jan 8, 2025
spikecurtis
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for #2.
This PR adds an abstraction for downloading & validating the dylib from a Coder server, and the network extension scaffolding.
It also adds a
TunnelHandletype for owning the pair of pipes passed to the dylib, and the handle to the dylib itself.You cannot create a unit test target that targets a System Extension. So, this PR extracts the portion of the network extension that we'd like to test into it's own Framework,
VPNLib.Of note is that
SwiftProtobufdoesn't have a stable ABI (as it doesn't use library evolution), so the Framework has theBuild libraries for distributionsetting disabled. This shouldn't effect anything. Exporting theSwiftProtobuftypes should be fine provided we don't importSwiftProtobufin to theVPNtarget as well.