chore: extract CoderSDK to framework #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
force-pushed
the
ethan/ne-manager
branch
from
300889e to
4922fcf
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
from
80e368b to
d92d916
Compare
ethanndickson
commented
Jan 10, 2025
| @@ -43,33 +43,4 @@ class MockSession: Session { | |||
| } | |||
| } | |||
|
|
|||
| struct MockClient: Client { | |||
There was a problem hiding this comment.
I much prefer using the Mocker mocks over plastering a generic type throughout the actual implementation.
ethanndickson
force-pushed
the
ethan/ne-manager
branch
from
4922fcf to
7e24349
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
from
d92d916 to
0c08c31
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
2 times, most recently
from
70bb805 to
46212d6
Compare
ethanndickson
force-pushed
the
ethan/ne-manager
branch
2 times, most recently
from
8964672 to
8b80132
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
2 times, most recently
from
0cb0f79 to
b5babf4
Compare
ethanndickson
force-pushed
the
ethan/ne-manager
branch
from
8ca39b4 to
279f004
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
from
b5babf4 to
7a7ece8
Compare
ethanndickson
changed the base branch from
ethan/ne-manager
to
graphite-base/19
ethanndickson
force-pushed
the
graphite-base/19
branch
from
279f004 to
46c2c09
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
from
7a7ece8 to
11b78f9
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
2 times, most recently
from
e1f515b to
d566412
Compare
ethanndickson
force-pushed
the
ethan/codersdk-refactor
branch
from
d566412 to
84936d0
Compare
coadler
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.
Extracts CoderSDK to a seperate framework so it can be used in both the application and the network extension.
The SDK is used when the network extension verifies the dylib, to retrieve the version of the server from
api/v2/buildinfo.Removes Alamofire as a dependency of the SDK, as
URLSessionis good enough.