Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest upgrade_schema_version runs upgrade script on all older versions #9488

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

jtcohen6
Copy link
Contributor

resolves #9487

Problem

  • Manifest upgrade_schema_version was hardcoded to only run the preprocessing upgrade script (upgrade_manifest_json) if the state-comparison manifest was <= 10 (a hard-coded value)
  • Instead, always run it if the state-comparison manifest version is older than the current version

Why didn't we catch this in test failures? Because the v11 manifest (incorrectly) included a unit_tests dictionary! We probably recreated it at some point during the unit testing work. I replaced it with a manifest I produced by actually running 1.7.latest.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@jtcohen6 jtcohen6 requested a review from a team as a code owner January 30, 2024 11:40
@jtcohen6 jtcohen6 requested a review from QMalcolm January 30, 2024 11:40
@cla-bot cla-bot bot added the cla:yes label Jan 30, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98bbbc1) 87.96% compared to head (751f4aa) 88.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9488      +/-   ##
==========================================
+ Coverage   87.96%   88.01%   +0.05%     
==========================================
  Files         166      166              
  Lines       22094    22093       -1     
==========================================
+ Hits        19435    19446      +11     
+ Misses       2659     2647      -12     
Flag Coverage Δ
integration 85.57% <100.00%> (+0.12%) ⬆️
unit 62.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 This makes soooo much more sense. Thank you for doing this!

@jtcohen6 jtcohen6 merged commit 9c8b28a into main Jan 30, 2024
51 checks passed
@jtcohen6 jtcohen6 deleted the jerco/fix-9487 branch January 30, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Manifest upgrade_schema_version needs to process v11 manifests
2 participants