Manifest upgrade_schema_version
runs upgrade script on all older versions
#9488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9487
Problem
upgrade_schema_version
was hardcoded to only run the preprocessing upgrade script (upgrade_manifest_json
) if the state-comparison manifest was<= 10
(a hard-coded value)Why didn't we catch this in test failures? Because the
v11
manifest (incorrectly) included aunit_tests
dictionary! We probably recreated it at some point during the unit testing work. I replaced it with a manifest I produced by actually running1.7.latest
.Checklist