Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest upgrade_schema_version runs upgrade script on all older versions #9488

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Manifest upgrade_schema_version runs upgrade script on all older versions #9488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b34163
Make test fail correctly
jtcohen6 Jan 30, 2024
9a17aab
Manifest upgrade_schema_version runs on any older version
jtcohen6 Jan 30, 2024
751f4aa
Add changelog entry
jtcohen6 Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20240130-124135.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: Run manifest upgrade preprocessing on any older manifest version, including
v11
time: 2024-01-30T12:41:35.899412+01:00
custom:
Author: jtcohen6
Issue: "9487"
2 changes: 1 addition & 1 deletion core/dbt/artifacts/schemas/manifest/v12/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
"""This overrides the "upgrade_schema_version" call in VersionedSchema (via
ArtifactMixin) to modify the dictionary passed in from earlier versions of the manifest."""
manifest_schema_version = get_artifact_schema_version(data)
if manifest_schema_version <= 10:
if manifest_schema_version < cls.dbt_schema_version.version:

Check warning on line 168 in core/dbt/artifacts/schemas/manifest/v12/manifest.py

View check run for this annotation

Codecov / codecov/patch

core/dbt/artifacts/schemas/manifest/v12/manifest.py#L168 

Added line #L168 was not covered by tests
data = upgrade_manifest_json(data, manifest_schema_version)
return cls.from_dict(data)

Expand Down
2 changes: 1 addition & 1 deletion tests/functional/artifacts/data/state/v11/manifest.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading