fixed existing tests #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you cancel hanging ci |
talentlessguy
requested changes
Aug 3, 2023
deno.jsonc
Outdated
| @@ -7,7 +7,7 @@ | |||
| "semiColons": false | |||
| }, | |||
| "tasks": { | |||
| "test": "deno test --allow-net --allow-read --coverage=coverage --parallel", | |||
| "test": "deno test --allow-net --allow-all --coverage=coverage --parallel", | |||
There was a problem hiding this comment.
--allow-all is insecure to use. if you meant to add a permission add it via --allow-{perm}
talentlessguy
requested changes
Aug 4, 2023
extensions/res/download.ts
Outdated
| @@ -9,21 +9,31 @@ export type DownloadOptions = | |||
| headers: Record<string, unknown> | |||
| }> | |||
|
|
|||
| type Callback = (err?: any) => void | |||
There was a problem hiding this comment.
avoid any wherever possible, use unknown instead
extensions/res/send/sendFile.ts
Outdated
| async ( | ||
| path: string, | ||
| { signal, ...opts }: SendFileOptions = {}, | ||
| cb?: (err?: any) => void, |
There was a problem hiding this comment.
better change it to unknown, we don't know what kind of error could be thrown
| @@ -74,7 +75,11 @@ async (path: string, { signal, ...opts }: SendFileOptions = {}) => { | |||
|
|
|||
| res._init.status = status | |||
|
|
|||
| const file = await Deno.readFile(path, { signal }) | |||
| let file | |||
There was a problem hiding this comment.
this can be instead wrapped in try catch
tests/core/app.test.ts
Outdated
|
|
||
| // await makeFetch(server)('/route').expect(200, 'A different route') | ||
| const server = app.handler |
There was a problem hiding this comment.
app handler is not a server, I think it's okay to just pass the app.handler to makeFetch directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.