fixed existing tests

extensions/res/download.ts

@@ -9,21 +9,31 @@ export type DownloadOptions =
     headers: Record<string, unknown>
   }>
 
+type Callback = (err?: any) => void
+
 export const download = <
   Req extends Request = Request,
   Res extends DummyResponse = DummyResponse,
 >(req: Req, res: Res) =>
 async (
   path: string,
-  filename?: string,
-  options: DownloadOptions = {},
+  filename?: string | Callback,
+  options?: DownloadOptions | Callback,
+  cb?: Callback,
 ): Promise<Res> => {
-  const name: string | null = filename as string
-  let opts: DownloadOptions = options
-
+  let name: string | null = filename as string
+  let done = cb
+  let opts: DownloadOptions = (options || null) as DownloadOptions
+  if (typeof filename === 'function') {
+    done = filename
+    name = null
+  } else if (typeof options === 'function') {
+    done = options
+  }
+  opts = opts || {}
   // set Content-Disposition when file is sent
   const headers: Record<string, string> = {
-    'Content-Disposition': contentDisposition(name || path),
+    'Content-Disposition': contentDisposition(basename(name || path)),
   }
 
   // merge user-provided headers
@@ -34,13 +44,16 @@ async (
       }
     }
   }
-
   // merge user-provided options
   opts = { ...opts, headers }
 
   // send file
 
-  return await sendFile<Req, Res>(req, res)(path, opts)
+  return await sendFile<Req, Res>(req, res)(
+    path,
+    opts,
+    done || (() => undefined),
+  )
 }
 
 export const attachment =

extensions/res/send/sendFile.ts

@@ -26,15 +26,17 @@ export const sendFile = <
   Req extends Request = Request,
   Res extends DummyResponse = DummyResponse,
 >(req: Req, res: Res) =>
-async (path: string, { signal, ...opts }: SendFileOptions = {}) => {
+async (
+  path: string,
+  { signal, ...opts }: SendFileOptions = {},
+  cb?: (err?: any) => void,
+) => {
   const { root, headers = {}, encoding = 'utf-8', ...options } = opts
-
   if (!_path.isAbsolute(path) && !root) {
     throw new TypeError('path must be absolute')
   }
 
   const filePath = root ? _path.join(root, path) : path
-
   const stats = await Deno.stat(filePath)
 
   headers['Content-Encoding'] = encoding
@@ -48,7 +50,6 @@ async (path: string, { signal, ...opts }: SendFileOptions = {}) => {
 
   headers['Content-Security-Policy'] = 'default-src \'none\''
   headers['X-Content-Type-Options'] = 'nosniff'
-
   let status = 200
 
   if (req.headers.get('range')) {
@@ -74,7 +75,11 @@ async (path: string, { signal, ...opts }: SendFileOptions = {}) => {
 
   res._init.status = status
 
-  const file = await Deno.readFile(path, { signal })
+  let file
+  await Deno.readFile(filePath, { signal }).then((f) => file = f).catch((e) => {
+    cb!(e)
+    file = null
+  })
 
   await send(req, res)(file)
 

router.ts

@@ -228,6 +228,17 @@ export class Router<
 
     return this
   }
+
+  all(...args: UseMethodParams): this {
+    const handlers = args.slice(1).flat()
+    pushMiddleware(this.middleware)({
+      path: args[0] as Handler,
+      handler: handlers[0] as Handler,
+      handlers: handlers.slice(1) as Handler[],
+      type: 'route'
+    })
+    return this
+  }
   /**
    * Return the app's absolute pathname
    * based on the parent(s) that have