-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies list in README #90
base: main
Are you sure you want to change the base?
Conversation
Add complete list of dependencies
Add complete list of dependencies required to build gtkcord4.
README.md
Outdated
@@ -12,8 +12,15 @@ | |||
|
|||
### Dependencies | |||
|
|||
gtkcord4 needs GTK4, gobject-introspection, and optionally libcanberra. If compiling, then the library | |||
headers are also required. | |||
Gtkcord4 needs the following dependencies met: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to lower-case?
Gtkcord4 needs the following dependencies met: | ||
|
||
``` | ||
golang git gtk4-devel gobject-introspection gobject-introspection-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golang
-> go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what distro are these packages for? Why are there -devel
packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Fedora and RHEL (and likely others), the -devel
suffix is used instead of -dev
.
These are needed at compile time for the library headers iirc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diamondburned, @asparkswghs is correct. Without these -devel
packages (Fedora's equivolent to -dev
), the system does not have the libraries necessary to compile GTK4 applications such as your own. Same with gobject...
. I've tested, and indeed installing these two packages is all that's necessary for the build to succeed on Fedora. Otherwise, your compile will not finish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a separate section for Fedora packages then? This seems to be pertaining to just Fedora.
Also, since so many people insist, I think it'd be better to just list out all the dependencies on every distro that people care enough about to PR in.
fixed capitalization
I've changed the dependencies section to now list every program the user must install to compile the program. The previous instructions were somewhat vague, and did not include
gobject-introspection-devel
orgtk4-devel
which are important and can cause a build to fail.