Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies list in README #90

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update dependencies list in README #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba062e3
Update README.md
Nov 19, 2022
4d0d9c2
Update README.md
Nov 19, 2022
1618432
Update README.md
Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,15 @@

### Dependencies

gtkcord4 needs GTK4, gobject-introspection, and optionally libcanberra. If compiling, then the library
headers are also required.
gtkcord4 needs the following dependencies met:

```
golang git gtk4-devel gobject-introspection gobject-introspection-devel
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golang -> go

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what distro are these packages for? Why are there -devel packages?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Fedora and RHEL (and likely others), the -devel suffix is used instead of -dev.
These are needed at compile time for the library headers iirc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diamondburned, @asparkswghs is correct. Without these -devel packages (Fedora's equivolent to -dev), the system does not have the libraries necessary to compile GTK4 applications such as your own. Same with gobject.... I've tested, and indeed installing these two packages is all that's necessary for the build to succeed on Fedora. Otherwise, your compile will not finish.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a separate section for Fedora packages then? This seems to be pertaining to just Fedora.

Also, since so many people insist, I think it'd be better to just list out all the dependencies on every distro that people care enough about to PR in.

```

Optionally (but recommended) install `libcanberra`

To build with libadwaita, you will need `libadwaita-devel`

### Pre-built Binary

Expand Down