dotnet watch run shouldn't disable the browser refresh logic injection on Linux
#28519
Conversation
ghost
added
the
area-commandlinetools
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
| // From emperical observation, it's noted that failing to launch a browser results in either Process.Start returning a null-value | ||
| // or for the process to have immediately exited. | ||
| // We can use this to provide a helpful message. | ||
| _reporter.Output($"Unable to launch the browser. Navigate to {launchUrl}"); |
There was a problem hiding this comment.
If there was an exception, won't they get "Unable to launch browser" twice, does that matter.
There was a problem hiding this comment.
One is with verbose logging enabled, which isn't common and normally filtered out. @pranavkm maybe change the first log though to remove the duplication?
There was a problem hiding this comment.
@pranavkm does this still need to be addressed?
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@pranavkm are you still trying to get this in for 5.0.2? Today is the cutoff - could you send mail to tactics to get approval? |
|
Moving to 5.0.3 as this didn't get tactics approved in time for 5.0.2 |
|
@pranavkm This almost fixes #25317 but unfortunately still couples the browser refresh to Before I saw this PR I created #28885 to decouple that setting with browser refreshing. When |
mkArtakMSFT
removed
the
Servicing-consider
|
I've removed the |
Prior to this change, inability or failure to launch a browser would result in the browser-refresh feature from being disabled. On Linux the feature is a bit flaky so we always disabled it. This change loosens up some of the restrictions. We always attempt to launch a browser and use heuristics to determine if launching failed. Additionally, the browser refresh feature is enabled regardless of how launching the browser fared.
dotnet watch runshouldn't disable the browser refresh logic injection on LinuxFixes #27081
Description
dotnet watch runrelies on OS's file associations to launch the browser the first time it's launched for ASP.NET Core apps. Support for this feature is is a bit iffy on Linux. We took a conservative approach in 5.0 RTM and disabled the ability to both launch the browser and refresh it. We have improved on this and can provide a helpful message when launching a browser did not work, and instruct the user to manually launch it. More importantly, we're able to make the browser refresh feature work all the time since the two are independent.Customer impact
dotnet watchsupport on Linux that is more consistent with other platforms.Regression
No
Risk
Low. The changes are limited to the dotnet-watch tool. We have CTI automation to cover using this and the changes were tested manually on some popular Linux flavors.