This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Add NodeJS stack with react realworld app #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
rhopp
approved these changes
Jul 8, 2019
type: dockerimage | ||
alias: nodejs | ||
# system limit for number of file watchers reached with | ||
# image: registry.access.redhat.com/ubi8/nodejs-10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this issue logged/tracked somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhopp
No. Should issue be created in eclipse/che repo?
l0rd
reviewed
Jul 8, 2019
l0rd
reviewed
Jul 8, 2019
l0rd
reviewed
Jul 8, 2019
l0rd
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a couple of minor comments but otherwise LGTM
Signed-off-by: Anatoliy Bazko <[email protected]>
5 tasks
nickboldt
pushed a commit
to nickboldt/che-devfile-registry
that referenced
this pull request
Aug 9, 2019
* Add NodeJS stack with react realworld app Signed-off-by: Anatoliy Bazko <[email protected]>
monaka
added a commit
that referenced
this pull request
Mar 14, 2020
Add `fetch-depth: 0` to actions/checkout@v2.
Ohrimenko1988
added a commit
that referenced
this pull request
Jun 3, 2020
Signed-off-by: Ihor Okhrimenko <[email protected]>
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
Add che-machine-exec plugin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko [email protected]
What does this PR do?
Adds NodeJS stack with the react realworld example [1]
Issues
It is not possible to use
registry.access.redhat.com/ubi8/nodejs-10
image due to errorsystem limit for number of file watchers reached
when server starts (npm start
).API_ROOT
[2] can't be modified due to issue [3]What issues does this PR fix or reference?
eclipse-che/che#13529
[1] https://github.com/gothinkster/react-redux-realworld-example-app
[2] https://github.com/gothinkster/react-redux-realworld-example-app/blob/master/src/agent.js#L6
[3] gothinkster/react-redux-realworld-example-app#134