Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize client-go performance by protobuf context-type. #1596

Closed
wants to merge 3 commits into from

Conversation

qicz
Copy link
Member

@qicz qicz commented Jun 26, 2023

What type of PR is this?
using protobuf context-type to optimize client-go performance.
image

using the json needs more memory and time
image

@qicz qicz requested a review from a team as a code owner June 26, 2023 14:54
@qicz qicz marked this pull request as draft June 26, 2023 14:54
@qicz qicz marked this pull request as ready for review June 26, 2023 15:02
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.77%. Comparing base (b7c1d37) to head (7d02978).
Report is 1544 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   61.85%   61.77%   -0.09%     
==========================================
  Files          81       81              
  Lines       12029    12025       -4     
==========================================
- Hits         7441     7428      -13     
- Misses       4131     4137       +6     
- Partials      457      460       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qicz qicz marked this pull request as draft June 26, 2023 15:44
@zirain
Copy link
Contributor

zirain commented Jun 30, 2023

please guard this with an env/cmd args, make it avaliable to fallback.

@qicz
Copy link
Member Author

qicz commented Jun 30, 2023

please guard this with an env/cmd args, make it avaliable to fallback.

I will do this PR at next version

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 30, 2023
@arkodg
Copy link
Contributor

arkodg commented Oct 10, 2023

@qicz is this still needed ?

@github-actions github-actions bot removed the stale label Oct 11, 2023
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@qicz
Copy link
Member Author

qicz commented Sep 27, 2024

xref: #4282 (comment)

@qicz qicz closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants