Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: optimize by protobuf context-type. #4282

Closed
wants to merge 3 commits into from

Conversation

qicz
Copy link
Member

@qicz qicz commented Sep 19, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

replace #1596
Fixes #

@qicz qicz requested a review from a team as a code owner September 19, 2024 06:47
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.56%. Comparing base (e043978) to head (8832ae1).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
internal/kubernetes/config.go 69.23% 3 Missing and 1 partial ⚠️
internal/infrastructure/manager.go 0.00% 1 Missing ⚠️
internal/provider/runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4282      +/-   ##
==========================================
- Coverage   65.64%   65.56%   -0.09%     
==========================================
  Files         197      198       +1     
  Lines       23534    23555      +21     
==========================================
- Hits        15450    15443       -7     
- Misses       6975     7007      +32     
+ Partials     1109     1105       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: qicz <[email protected]>
@zirain
Copy link
Contributor

zirain commented Sep 19, 2024

is there before-and-after data comparison?

@qicz
Copy link
Member Author

qicz commented Sep 19, 2024

/retest

@qicz
Copy link
Member Author

qicz commented Sep 19, 2024

the gateway API does not support protobuf. raised issue kubernetes-sigs/gateway-api#3346
the same for EG. #4283

@qicz qicz marked this pull request as draft September 25, 2024 10:00
@qicz
Copy link
Member Author

qicz commented Sep 27, 2024

xref: #4283 (comment)
#4283 (comment)

EG has already supported multi content-type by controller-runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants