Change OcrNumbersTest
to use optionals
#848
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the current tests for this exercise do not match the description in
instructions.md
:However, the relevant tests look like this:
This feels doubly wrong because the tests neither test for returning an error (as indicated in the instructions) nor do they test for raising an error (as per the test descriptions).
So this PR changes all tests to use
Optional[String]
as the return type, withNone
being asserted for the two tests listed above.I also think we should add two additional tests: both
List()
andList("", "", "", "")
should IMO returnNone
, not "?", so I added those in a second commit.I understand this will make all existing solutions fail the test suite when they re-run, but I think it's worth it. It's also more consistent with other exercises, which use optionals in a similar way (e.g. Grains, Hamming Distance, Largest Series Product, Queen Attack.)