Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OcrNumbersTest to use optionals #848

Closed
wants to merge 2 commits into from
Closed

Change OcrNumbersTest to use optionals #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf8ef8
Change OcrNumbersTest to use optionals
citizen428 Dec 22, 2024
184cfa1
Add two additional test cases to OcrNumbersTest
citizen428 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 30 additions & 19 deletions exercises/practice/ocr-numbers/src/test/scala/OcrNumbersTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,40 +9,51 @@ class OcrNumbersTest extends AnyFunSuite with Matchers {
OcrNumbers.convert(List(" _ ",
"| |",
"|_|",
" ")) should be("0")
" ")) should be(Some("0"))
}

test("Recognizes 1") {
pending
OcrNumbers.convert(List(" ",
" |",
" |",
" ")) should be("1")
" ")) should be(Some("1"))
}

test("Unreadable but correctly sized inputs return ?") {
pending
OcrNumbers.convert(List(" ",
" _",
" |",
" ")) should be("?")
" ")) should be(Some("?"))
}

test("Input with no lines returns None") {
pending
OcrNumbers.convert(List()) should be(None)
}

test(
"Input with a number of lines that is not a multiple of four raises an error") {
"Input with a number of lines that is not a multiple of four returns None") {
pending
OcrNumbers.convert(List(" _ ",
"| |",
" ")) should be("?")
" ")) should be(None)
}

test("Input with empty columns returns None") {
pending
OcrNumbers.convert(List("", "", "", "")) should be(None)
}


test(
"Input with a number of columns that is not a multiple of three raises an error") {
"Input with a number of columns that is not a multiple of three returns None") {
pending
OcrNumbers.convert(List(" ",
" |",
" |",
" ")) should be("?")
" ")) should be(None)
}

test("Recognizes 110101100") {
Expand All @@ -51,7 +62,7 @@ class OcrNumbersTest extends AnyFunSuite with Matchers {
List(" _ _ _ _ ",
" | || | || | | || || |",
" | ||_| ||_| | ||_||_|",
" ")) should be("110101100")
" ")) should be(Some("110101100"))
}

test("Garbled numbers in a string are replaced with ?") {
Expand All @@ -60,71 +71,71 @@ class OcrNumbersTest extends AnyFunSuite with Matchers {
List(" _ _ _ ",
" | || | || | || || |",
" | | _| ||_| | ||_||_|",
" ")) should be("11?10?1?0")
" ")) should be(Some("11?10?1?0"))
}

test("Recognizes 2") {
pending
OcrNumbers.convert(List(" _ ",
" _|",
"|_ ",
" ")) should be("2")
" ")) should be(Some("2"))
}

test("Recognizes 3") {
pending
OcrNumbers.convert(List(" _ ",
" _|",
" _|",
" ")) should be("3")
" ")) should be(Some("3"))
}

test("Recognizes 4") {
pending
OcrNumbers.convert(List(" ",
"|_|",
" |",
" ")) should be("4")
" ")) should be(Some("4"))
}

test("Recognizes 5") {
pending
OcrNumbers.convert(List(" _ ",
"|_ ",
" _|",
" ")) should be("5")
" ")) should be(Some("5"))
}

test("Recognizes 6") {
pending
OcrNumbers.convert(List(" _ ",
"|_ ",
"|_|",
" ")) should be("6")
" ")) should be(Some("6"))
}

test("Recognizes 7") {
pending
OcrNumbers.convert(List(" _ ",
" |",
" |",
" ")) should be("7")
" ")) should be(Some("7"))
}

test("Recognizes 8") {
pending
OcrNumbers.convert(List(" _ ",
"|_|",
"|_|",
" ")) should be("8")
" ")) should be(Some("8"))
}

test("Recognizes 9") {
pending
OcrNumbers.convert(List(" _ ",
"|_|",
" _|",
" ")) should be("9")
" ")) should be(Some("9"))
}

test("Recognizes string of decimal numbers") {
Expand All @@ -133,7 +144,7 @@ class OcrNumbersTest extends AnyFunSuite with Matchers {
List(" _ _ _ _ _ _ _ _ ",
" | _| _||_||_ |_ ||_||_|| |",
" ||_ _| | _||_| ||_| _||_|",
" ")) should be("1234567890")
" ")) should be(Some("1234567890"))
}

test(
Expand All @@ -151,6 +162,6 @@ class OcrNumbersTest extends AnyFunSuite with Matchers {
" _ _ _ ",
" ||_||_|",
" ||_| _|",
" ")) should be("123,456,789")
" ")) should be(Some("123,456,789"))
}
}