Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External screens not available (until restart of Flameshot) #3505

Open
tpcgold opened this issue Feb 20, 2024 · 9 comments
Open

External screens not available (until restart of Flameshot) #3505

tpcgold opened this issue Feb 20, 2024 · 9 comments
Labels
MacOS MacOS related Unconfirmed Bug The bug is not confirmed by anyone else.

Comments

@tpcgold
Copy link

tpcgold commented Feb 20, 2024

Flameshot Version

v12.1.0 (96c2c82)

Installation Type

brew install --cask flameshot

Operating System type and version

Soonoma 14.3.1

Description

Flameshot area doesn't extend to external screens when plugging them in.
So taking a screenshot or "selection" only involves the main display of the M2 Mac.

Tried to reinstalled etc. but the problem still occures (this problem exists since a few months)

Current workaround found: close flameshot and reopen -> but this is really annoying over time

Steps to reproduce

  1. start Mac
  2. add external Screen via usb-c/thunderbolt
  3. problem occurs

Screenshots or screen recordings

No response

System Information

  1. macOS Soonoma 14.3.1
  2. Mac M2 with two Dell external Screens or Mac M2 with Samsung external Screen
@lateparty
Copy link

Second this on Windows. Flameshot snapshots your multi-screen configuration on startup and then keeps that regardless of plugging or unplugging and moving to different setups with the device. Would love a fix for this.

@tpcgold
Copy link
Author

tpcgold commented Feb 27, 2024

seems the problem could be fixed by using:
https://doc.qt.io/qt-6/qguiapplication.html#screenAdded

(but I'm not a contributor atm. and don't have time to read into the code. just this trigger doesn't occur in the code anywhere , although it seems it should)
Also this trigger should occur:
https://doc.qt.io/qt-6/qguiapplication.html#screenRemoved

@man0s

This comment was marked as duplicate.

@johannesE
Copy link

johannesE commented May 24, 2024

I can confirm that restarting flameshot on OSX fixed the issue for me.

EDIT: fixed it temporarily as @Saibamen pointed out.

@Saibamen
Copy link
Contributor

fixed the issue for me

This is a workaround, not fixing

@leehambley
Copy link

I'm trying today to apply the advice from #3505 (comment) and see if that works in general, if it does I'll link my pull request here. First impressions are good, but I'm not fluent in C++ or QT so I can't promise anything.

leehambley added a commit to leehambley/flameshot that referenced this issue May 27, 2024
…niitalize Flameshot when the display configuration changes
leehambley added a commit to leehambley/flameshot that referenced this issue May 27, 2024
…niitalize Flameshot when the display configuration changes
@leehambley
Copy link

PR here but I don't know if it really really helps. You can try cloning my branch and building with

brew install qt@5 cmake
cmake -S . -B build -DQt5_DIR=$(brew --prefix qt5)/lib/cmake/Qt5 && (cd build && make)
open build/src/flameshot.app

@RichDCs
Copy link

RichDCs commented Jun 14, 2024

@leehambley Tried it, it does detect the external monitor (even after unplugging and plugging again) 👍

However, it introduces a couple of regressions:

  • The screenshot capture on the external monitor does not show any open windows. You can only screenshot an empty screen.
  • It adds an additional window on the main monitor - to now dismiss the screenshot mode, you have to press esc -> click on the main monitor to focus -> press esc again.

Tested on MacBook Air M2 with 1 external monitor.

@nikhilweee
Copy link

Came here to say that I love Flameshot but this has been bugging me for a while now. The most annoying part is when I right click on the taskbar icon to quit flameshot but I can only see the first menu item because the rest of it is off the screen. Would love to see some progress here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MacOS MacOS related Unconfirmed Bug The bug is not confirmed by anyone else.
Projects
None yet
Development

No branches or pull requests

9 participants