Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3505] use QT APIs screenAdded and screenRemoved to reiniitalize Fla… #3618

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#3505] use QT APIs screenAdded and screenRemoved to reiniitalize Fla… #3618

wants to merge 2 commits into from

Conversation

leehambley
Copy link

…meshot when the display configuration changes

@leehambley
[flameshot-org#3505] use QT APIs screenAdded and screenRemoved to rei…
7c7e98d 
…niitalize Flameshot when the display configuration changes
@leehambley leehambley force-pushed the flameshot-3505-external-screens-not-available-until-restarted branch from 4b54150 to 7c7e98d Compare May 27, 2024 09:05
@leehambley leehambley mentioned this pull request May 27, 2024
Open
Saibamen
Saibamen reviewed May 27, 2024
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@Saibamen
Copy link
Contributor

#3505 (comment):

@leehambley Tried it, it does detect the external monitor (even after unplugging and plugging again) 👍

However, it introduces a couple of regressions:

  • The screenshot capture on the external monitor does not show any open windows. You can only screenshot an empty screen.
  • It adds an additional window on the main monitor - to now dismiss the screenshot mode, you have to press esc -> click on the main monitor to focus -> press esc again.

Tested on MacBook Air M2 with 1 external monitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saibamen Saibamen Saibamen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leehambley @Saibamen