Remove QEMU dummy package installation from Linux-pack.yml #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QEMU package is now a dummy package. Installing qemu-user-static should be sufficient. See https://packages.debian.org/buster/qemu for official mention of it being a dummy package.
|
Putting on hold as there seems to be an issue later on in the build process.
|
|
Actually all the others succeeded, only this arm64 and the fedora ones failed.
|
|
@volovikariel thanks for the PR and being careful about which CI breaks. @holazt what's your opinion on this? |
|
LGTM |
mmahmoudian
approved these changes
Feb 26, 2025
|
@volovikariel thanks for the PR |
volovikariel
added a commit
to volovikariel/flameshot
that referenced
this pull request
Feb 27, 2025
Remove QEMU dummy package installation from Linux-pack.yml (flameshot-org#3851)
volovikariel
added a commit
to volovikariel/flameshot
that referenced
this pull request
Feb 27, 2025
Remove QEMU dummy package installation from Linux-pack.yml (flameshot-org#3851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I don't want the CI to fail when tests are run on ARM
Solution reasoning:
The QEMU package is now a dummy package. Installing
qemu-user-staticshould keep functionality and fix the failing workflow.See https://packages.debian.org/buster/qemu and https://packages.debian.org/bullseye/qemu for official mention of it being a dummy package.
Current state CI run: https://github.com/volovikariel/flameshot/actions/runs/13458590444
With this change: https://github.com/volovikariel/flameshot/actions/runs/13458428232