feat(babel-istanbul): stopped including the plugin since it is not ne…

…eded with c8
form8ion · Jun 3, 2022 · 18daef0 · 18daef0
1 parent d94a8a3
commit 18daef0
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 40 deletions.
diff --git a/src/scaffolder/dialects/babel-test.js b/src/scaffolder/dialects/babel-test.js
@@ -24,27 +24,6 @@ suite('babel config', () => {
 
     assert.deepEqual(
       await scaffoldBabel({preset: babelPreset, projectRoot, tests: {unit: true}, buildDirectory}),
-      {devDependencies: ['@babel/register', babelPresetPackageName, 'babel-plugin-istanbul'], eslint: {}}
-    );
-
-    assert.calledWith(
-      fs.writeFile,
-      `${projectRoot}/.babelrc`,
-      JSON.stringify({
-        presets: [babelPresetName],
-        ignore: [`./${buildDirectory}/`],
-        env: {test: {plugins: ['istanbul']}}
-      })
-    );
-  });
-
-  test('that the istanbul plugin dependency is not included if unit testing is not desired', async () => {
-    const babelPresetName = any.string();
-    const babelPresetPackageName = any.word();
-    const babelPreset = {name: babelPresetName, packageName: babelPresetPackageName};
-
-    assert.deepEqual(
-      await scaffoldBabel({preset: babelPreset, projectRoot, tests: {unit: false}, buildDirectory}),
       {devDependencies: ['@babel/register', babelPresetPackageName], eslint: {}}
     );
 

diff --git a/src/scaffolder/dialects/babel.js b/src/scaffolder/dialects/babel.js
@@ -1,25 +1,17 @@
 import {promises as fsPromises} from 'fs';
 
-export default async function ({projectRoot, preset, tests, buildDirectory}) {
+export default async function ({projectRoot, preset, buildDirectory}) {
   if (!preset) {
     throw new Error('No babel preset provided. Cannot configure babel transpilation');
   }
 
   await fsPromises.writeFile(
     `${projectRoot}/.babelrc`,
-    JSON.stringify({
-      presets: [preset.name],
-      ignore: [`./${buildDirectory}/`],
-      ...tests.unit && {env: {test: {plugins: ['istanbul']}}}
-    })
+    JSON.stringify({presets: [preset.name], ignore: [`./${buildDirectory}/`]})
   );
 
   return {
-    devDependencies: [
-      '@babel/register',
-      preset.packageName,
-      ...tests.unit ? ['babel-plugin-istanbul'] : []
-    ],
+    devDependencies: ['@babel/register', preset.packageName],
     eslint: {}
   };
 }
diff --git a/src/scaffolder/dialects/scaffolder-test.js b/src/scaffolder/dialects/scaffolder-test.js
@@ -23,13 +23,12 @@ suite('scaffold dialect', () => {
 
   test('that babel is scaffolded when chosen', async () => {
     const babelPreset = any.word();
-    const tests = any.simpleObject();
     const buildDirectory = any.string();
     const babelResults = any.simpleObject();
-    babel.default.withArgs({preset: babelPreset, projectRoot, tests, buildDirectory}).resolves(babelResults);
+    babel.default.withArgs({preset: babelPreset, projectRoot, buildDirectory}).resolves(babelResults);
 
     assert.equal(
-      await scaffoldDialect({dialect: dialects.BABEL, configs: {babelPreset}, projectRoot, tests, buildDirectory}),
+      await scaffoldDialect({dialect: dialects.BABEL, configs: {babelPreset}, projectRoot, buildDirectory}),
       babelResults
     );
   });

diff --git a/src/scaffolder/dialects/scaffolder.js b/src/scaffolder/dialects/scaffolder.js
@@ -4,10 +4,10 @@ import scaffoldBabel from './babel';
 import scaffoldTypescript from './typescript';
 import scaffoldEsm from './esm';
 
-export default function ({dialect, projectType, projectRoot, configs, tests, buildDirectory, testFilenamePattern}) {
+export default function ({dialect, projectType, projectRoot, configs, buildDirectory, testFilenamePattern}) {
   switch (dialect) {
     case dialects.BABEL:
-      return scaffoldBabel({preset: configs.babelPreset, projectRoot, tests, buildDirectory});
+      return scaffoldBabel({preset: configs.babelPreset, projectRoot, buildDirectory});
     case dialects.TYPESCRIPT:
       return scaffoldTypescript({config: configs.typescript, projectType, projectRoot, testFilenamePattern});
     case dialects.ESM:

diff --git a/src/scaffolder/scaffolder-test.js b/src/scaffolder/scaffolder-test.js
@@ -216,7 +216,6 @@ suite('javascript project scaffolder', () => {
         projectRoot,
         projectType,
         configs,
-        tests,
         buildDirectory: projectTypeBuildDirectory,
         dialect: chosenDialect,
         testFilenamePattern
@@ -279,7 +278,6 @@ suite('javascript project scaffolder', () => {
           configs,
           projectRoot,
           projectType,
-          tests,
           buildDirectory: projectTypeBuildDirectory,
           dialect: chosenDialect,
           testFilenamePattern

diff --git a/src/scaffolder/scaffolder.js b/src/scaffolder/scaffolder.js
@@ -101,7 +101,6 @@ export default async function (options) {
       configs,
       projectRoot,
       projectType,
-      tests,
       buildDirectory: projectTypeResults.buildDirectory,
       testFilenamePattern: verificationResults.testFilenamePattern
     })