feat(babelrc): included the file extension on the file for better edi…

…tor support

and leveraged the new config-file writer to simplify the details

package.json

@@ -91,6 +91,7 @@
   "dependencies": {
     "@form8ion/codecov": "^3.0.0",
     "@form8ion/commit-convention": "^2.0.0",
+    "@form8ion/config-file": "^1.0.0-alpha.1",
     "@form8ion/core": "^1.5.0",
     "@form8ion/eslint": "^2.0.1",
     "@form8ion/husky": "^2.3.0",

src/scaffolder/dialects/babel-test.js

@@ -1,7 +1,10 @@
-import {promises as fs} from 'fs';
+import {fileTypes} from '@form8ion/core';
+import * as configFile from '@form8ion/config-file';
+
 import sinon from 'sinon';
 import {assert} from 'chai';
 import any from '@travi/any';
+
 import scaffoldBabel from './babel';
 
 suite('babel config', () => {
@@ -12,7 +15,7 @@ suite('babel config', () => {
   setup(() => {
     sandbox = sinon.createSandbox();
 
-    sandbox.stub(fs, 'writeFile');
+    sandbox.stub(configFile, 'write');
   });
 
   teardown(() => sandbox.restore());
@@ -28,9 +31,13 @@ suite('babel config', () => {
     );
 
     assert.calledWith(
-      fs.writeFile,
-      `${projectRoot}/.babelrc`,
-      JSON.stringify({presets: [babelPresetName], ignore: [`./${buildDirectory}/`]})
+      configFile.write,
+      {
+        path: projectRoot,
+        name: 'babel',
+        format: fileTypes.JSON,
+        config: {presets: [babelPresetName], ignore: [`./${buildDirectory}/`]}
+      }
     );
   });
 
@@ -40,7 +47,7 @@ suite('babel config', () => {
 
       throw new Error('test should have failed, but didnt');
     } catch (e) {
-      assert.notCalled(fs.writeFile);
+      assert.notCalled(configFile.write);
       assert.equal(e.message, 'No babel preset provided. Cannot configure babel transpilation');
     }
   });

src/scaffolder/dialects/babel.js

@@ -1,14 +1,17 @@
-import {promises as fsPromises} from 'fs';
+import {write} from '@form8ion/config-file';
+import {fileTypes} from '@form8ion/core';
 
 export default async function ({projectRoot, preset, buildDirectory}) {
   if (!preset) {
     throw new Error('No babel preset provided. Cannot configure babel transpilation');
   }
 
-  await fsPromises.writeFile(
-    `${projectRoot}/.babelrc`,
-    JSON.stringify({presets: [preset.name], ignore: [`./${buildDirectory}/`]})
-  );
+  await write({
+    path: projectRoot,
+    name: 'babel',
+    format: fileTypes.JSON,
+    config: {presets: [preset.name], ignore: [`./${buildDirectory}/`]}
+  });
 
   return {
     devDependencies: ['@babel/register', preset.packageName],

test/integration/features/step_definitions/dialect-steps.js

@@ -7,12 +7,12 @@ import any from '@travi/any';
 import {assertDevDependencyIsInstalled} from './common-steps';
 
 async function assertBabelIsNotConfigured() {
-  assert.isFalse(await fileExists(`${process.cwd()}/.babelrc`));
+  assert.isFalse(await fileExists(`${process.cwd()}/.babelrc.json`));
 }
 
 async function assertBabelDialectDetailsAreCorrect(babelPreset, buildDirectory, execa) {
   const [babelRcContents, packageContents] = await Promise.all([
-    fs.readFile(`${process.cwd()}/.babelrc`, 'utf-8'),
+    fs.readFile(`${process.cwd()}/.babelrc.json`, 'utf-8'),
     fs.readFile(`${process.cwd()}/package.json`, 'utf-8')
   ]);
   const {presets, ignore} = JSON.parse(babelRcContents);