feat: Recaptcha verification during signup #2444
Conversation
|
@atm1504 Please review |
| @@ -37,6 +41,7 @@ class SignUpActivity : AppCompatActivity(), ISignUpView { | |||
| private lateinit var forgotPasswordProgressDialog: Dialog | |||
| private lateinit var builder: AlertDialog.Builder | |||
| private var checkDialog: Boolean = false | |||
| private val RECAPTCHA_KEY = "6LcKhbMUAAAAAGFbYZeNFzqol-7EjOHUK5MvEeOE" | |||
There was a problem hiding this comment.
This shouldn't be hardcoded
There was a problem hiding this comment.
What else can I do to avoid this @iamareebjamal
There was a problem hiding this comment.
See where all configs are placed
| } | ||
| }) | ||
| .addOnFailureListener(this, OnFailureListener { e -> | ||
| Timber.e("Error: " + e) |
There was a problem hiding this comment.
Not correct way of using Timber.e
|
The screenshot you provided has been copied from #2360 |
|
@atm1504 I don't think this is a case of plagiarism. |
|
OK @atm1504 Why should copying your screenshot, or even your code be considered plagiarism? You contributed that as open source. Unless you have complete your PR, why shouldn't anyone else even use your code to do it? And here, it's not even code being copied. I don't think you understand plagiarism. Screenshot was not even required in the PR. |
|
@iamareebjamal I don't consider copying code as plagiarism in open source. But the thing is that this pr was created without even testing the code, which can be proved directly by seeing the screenshot. |
|
You didn't write any of that. Only about screenshot being copied |
|
@iamareebjamal that was my fault that I didn't mention all the reasons. |
|
@atm1504 I checked it with my key but I thought that maybe the key you used previously was still active and is in current use. |
Fixes #2350
Changes: Add recaptcha during signup.
Screenshots for the change:
