Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for Visualize Frustum #2794

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ntfshard
Copy link
Contributor

🦟 Bug fix

Fixes #

Summary

As discussed in initial PR, code can be simplified and optimized by avoiding unnecessary copying

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ntfshard ntfshard requested a review from mjcarroll as a code owner February 22, 2025 17:38
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Feb 22, 2025
@ntfshard ntfshard force-pushed the vis_frustum_cleanup branch from 88219fc to 56a3bc1 Compare February 22, 2025 18:06
Signed-off-by: Maksim Derbasov <[email protected]>
@ntfshard ntfshard force-pushed the vis_frustum_cleanup branch from 56a3bc1 to 73b00a9 Compare February 22, 2025 18:33
@ahcorde ahcorde merged commit b2c4b27 into gazebosim:gz-sim9 Feb 24, 2025
11 checks passed
@ntfshard ntfshard deleted the vis_frustum_cleanup branch February 24, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants