Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): Remove child props from attachments page #80776

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

scttcper
Copy link
Member

The goal is to remove cloneElement and passing untyped props from groupDetails down to child routes. We could also start loading sub requests earlier for some of these pages.

const childProps = {
environments,
group,
project,
event,
loadingEvent,
eventError,
groupReprocessingStatus,
onRetry: refetchData,
baseUrl,
};

The goal is to remove cloneElement and passing untyped props from groupDetails down to child routes. We could also start loading sub requests earlier for some of these pages.

https://github.com/getsentry/sentry/blob/f4a29f737fe9e46716468934b68dadb3605f03b9/static/app/views/issueDetails/groupDetails.tsx#L651-L661
@scttcper scttcper requested a review from a team as a code owner November 14, 2024 20:55
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2024
@scttcper scttcper merged commit d41a62e into master Nov 14, 2024
43 of 44 checks passed
@scttcper scttcper deleted the scttcper/attachment-props branch November 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants