Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(issues): Remove child props from attachments page #80776

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat(issues): Remove child props from attachments page #80776

merged 1 commit into from
Nov 14, 2024
+21 −7

Commits on Nov 14, 2024

  1. feat(issues): Remove child props from attachments page 

    The goal is to remove cloneElement and passing untyped props from groupDetails down to child routes. We could also start loading sub requests earlier for some of these pages.

https://github.com/getsentry/sentry/blob/f4a29f737fe9e46716468934b68dadb3605f03b9/static/app/views/issueDetails/groupDetails.tsx#L651-L661
    @scttcper
    scttcper committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0fe4143 View commit details
    Browse the repository at this point in the history