Improve the file list checkboxes behavior #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so that the indeterminate state of the checkbox matches the selected style
Create a module for array utilities. Add a function that determines what amount of items in an array satisfy a condition
If only some of the hunks have been selected, display the file checkbox as indeterminate
Deduplicate and move the chunk utility into the array utilities module
Refactor and clean-up the component, so that the newer, more readable Svelte 5 state APIs are used
Rename the `Ownership` class to `SelectedOwnership`, as it is only used to determine the selected state of the files to add to a commit. Renamed the methods as well to convey their actual purpose. The `SelectedOwnership` class will be updated in a way that the selected is persisted across file/hunk ownership updates
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
df41345
to
87b8cbb
Compare
estib-vega
requested review from
PavelLaptev,
mtsgrd,
Caleb-T-Owens and
ndom91
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
87b8cbb
to
da25785
Compare
|
Missing some style updates |
estib-vega
changed the title
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
da25785
to
908f4f0
Compare
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
908f4f0
to
af12e19
Compare
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
af12e19
to
351c6ed
Compare
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
351c6ed
to
5c3c8ca
Compare
mtsgrd
approved these changes
Sep 10, 2024
estib-vega
force-pushed
the
check-boxes-behavior
branch
from
5c3c8ca
to
3ad6691
Compare
estib-vega
force-pushed
the
check-boxes-behavior
branch
2 times, most recently
from
650a20e
to
d203a3d
Compare
|
@PavelLaptev 
|
estib-vega
force-pushed
the
check-boxes-behavior
branch
2 times, most recently
from
4f43d03
to
aaae6e6
Compare
PavelLaptev
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As seen in #4846
There are some funky behaviors to our file checkboxes, this PR updates the style and behavior so that:
Changes
1. Update the Ownership class
Rename the
Ownershipclass toSelectedOwnership, as it is only used to determine the selected state of the files to add to a commit.Renamed the methods as well to convey their actual purpose.
The
SelectedOwnershipclass will be updated in a way that the selected is persisted across file/hunk ownership updates2. Track whether a file is partially selected or not
If only some hunks are selected, display the
indeterminatecheckbox state for that file3. Design update
Update the style of the
indeterminatecheckbox state