Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the file list checkboxes behavior #4859

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Commits on Sep 8, 2024

  1. Style: Checkbox indeterminate state

    Make it so that the indeterminate state of the checkbox matches the selected style
    estib-vega committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d3c1ed8 View commit details
    Browse the repository at this point in the history
  2. Utils: Check for array items compliance

    Create a module for array utilities.
    Add a function that determines what amount of items in an array satisfy a condition
    estib-vega committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d7c8c78 View commit details
    Browse the repository at this point in the history
  3. FileListItem: Track whether all or some hunks have been selected

    If only some of the hunks have been selected, display the file checkbox as indeterminate
    estib-vega committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0a64930 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Move chunk to array utilities

    Deduplicate and move the chunk utility into the array utilities module
    estib-vega committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    660c555 View commit details
    Browse the repository at this point in the history
  2. BranchFilesList: Clean-up and prefer Svelte 5 APIs

    Refactor and clean-up the component, so that the newer, more readable Svelte 5 state APIs are used
    estib-vega committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7bb3c7c View commit details
    Browse the repository at this point in the history
  3. Update Ownership class

    Rename the `Ownership` class to `SelectedOwnership`, as it is only used to determine the selected state of the files to add to a commit.
    
    Renamed the methods as well to convey their actual purpose.
    
    The `SelectedOwnership` class will be updated in a way that the selected is persisted across file/hunk ownership updates
    estib-vega committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8c22b6c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    aaae6e6 View commit details
    Browse the repository at this point in the history