null-safety & some other cleanup #16
Conversation
| repeatAfter: repeatAfter ?? this.repeatAfter, | ||
| subtasks: subtasks ?? this.subtasks, | ||
| labels: labels ?? this.labels, | ||
| attachments: attachments ?? this.attachments, |
There was a problem hiding this comment.
The idea of the copyWith method is that it returns a copy of the Task with the modifications specified.
|
I think the check might be failing because there is a new version of Flutter available and it's trying to use the newer versions which are incompatible with the versions in the pubspec.lock maybe? |
lib/models/list.dart
Outdated
| 'created': created.toIso8601String(), | ||
| 'updated': updated.toIso8601String(), |
There was a problem hiding this comment.
.toUtc is needed here and in every other toJSON as the API fails to handle timestamps with timezones correctly. I'm not sure if this is the API's fault or flutter's. toUtc is a workaround, we should probably address this at some point in the future.
There was a problem hiding this comment.
Hmm, seems to work for me. When I made requests directly (in python) it was giving me the proper timezone and it didn't seem to have difficulty when I gave it back. I added the .toUtc() anyway.
Regardless, I'm not sure these are editable for the client as the documentation for 'updated' says:
updated
string
A timestamp when this task was last updated. You cannot change this value.
So perhaps we should remove the 'created' and 'updated' from the toJSONs?
|
Thanks so much for your work! Merged it and will release a new version soon |
|
Nice work you two! |
|
Don't merge it into main quite yet. Just realized there is a couple other quirks, such as not being able to remove due dates. I'll submit another PR shortly. |
|
Sorry, read your comment too late. Create a new PR and I'll merge it. |
Cleans up the null-safety migration and does a little other cleanup.