V5.2.0 release #326
Open
V5.2.0 release #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto v5.2.0-release
| \n if(fynd_platform_cdn) { | ||
| \n cdnUrl = fynd_platform_cdn | ||
| \n } else { | ||
| \n throw new Error("undefiend variable")} |
There was a problem hiding this comment.
Why throwing error is needed when simply assignment of assetNormalizedBasePath is required?
Also code needs to be formatted
There was a problem hiding this comment.
We can omit try-catch altogether here, Doesn't seems it is required here.
| @@ -350,6 +348,10 @@ export default class Theme { | |||
| }); | |||
| config['application_id'] = selectedApplication; | |||
| config['company_id'] = selectedCompany; | |||
| // config['application_id'] = "6672cdcc9399006687477a5c"; | |||
| // config['company_id'] = 63; | |||
| console.log({config}); | |||
There was a problem hiding this comment.
remove comments and logs
| @@ -822,7 +821,7 @@ export default class Theme { | |||
| const currentContext = getActiveContext(); | |||
| switch (currentContext.theme_type) { | |||
| case THEME_TYPE.react: | |||
| await Theme.syncReactTheme(currentContext); | |||
| await Theme.syncReactTheme(currentContext, undefined); | |||
There was a problem hiding this comment.
why undefined needs to be passed here?
Shivraj0
reviewed
Jul 12, 2024
| \n if(fynd_platform_cdn) { | ||
| \n cdnUrl = fynd_platform_cdn | ||
| \n } else { | ||
| \n throw new Error("undefiend variable")} |
There was a problem hiding this comment.
We can omit try-catch altogether here, Doesn't seems it is required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges
https://github.com/gofynd/fdk-cli/pull/323
https://github.com/gofynd/fdk-cli/pull/322
https://github.com/gofynd/fdk-cli/pull/316/