Extension asset upload #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const isNodeVersionIsGreaterThan18 = | ||
| +process.version.split('.')[0].slice(1) >= 18; | ||
| let b = exec( | ||
| `node ${VUE_CLI_PATH} build --target lib src/index.js --name ${bundleName}`, | ||
| `node ${VUE_CLI_PATH} build --target lib src/index.js --name ${bundleName} --filename ${assetHash}_${bundleName}`, |
Check failure
Code scanning / CodeQL
Uncontrolled command line Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we should avoid using exec with a single concatenated string that includes user input. Instead, we can use execFile or execFileSync, which allows us to pass command arguments as an array of strings. This approach is safer and mitigates the risk of command injection.
- Replace the
execfunction withexecFile. - Pass the command and its arguments as separate elements in an array.
- Ensure that the
bundleNameand other variables are passed as separate arguments to avoid shell interpretation.
Suggested changeset
1
src/lib/ExtensionSection.ts
| @@ -26,3 +26,3 @@ | ||
| import inquirer from 'inquirer'; | ||
| import { exec } from 'child_process'; | ||
| import { execFile } from 'child_process'; | ||
| import * as cheerio from 'cheerio'; | ||
| @@ -549,4 +549,12 @@ | ||
| +process.version.split('.')[0].slice(1) >= 18; | ||
| let b = exec( | ||
| `node ${VUE_CLI_PATH} build --target lib src/index.js --name ${bundleName} --filename ${assetHash}_${bundleName}`, | ||
| let b = execFile( | ||
| 'node', | ||
| [ | ||
| VUE_CLI_PATH, | ||
| 'build', | ||
| '--target', 'lib', | ||
| 'src/index.js', | ||
| '--name', bundleName, | ||
| '--filename', `${assetHash}_${bundleName}` | ||
| ], | ||
| { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.