Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: add Federation-frontend dashboard #10697

Merged
merged 5 commits into from
Feb 20, 2025
Merged

mixin: add Federation-frontend dashboard #10697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3607cdf
Add FF WIP
dimitarvdimitrov Feb 19, 2025
363c791
Fix query panels
dimitarvdimitrov Feb 19, 2025
e2f66a8
Allow running mixin-serve for different mixins
dimitarvdimitrov Feb 19, 2025
8970f15
Remove comments
dimitarvdimitrov Feb 19, 2025
778aad2
Add CHANGELOG.md entry
dimitarvdimitrov Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
* [ENHANCEMENT] Dashboards: 'Writes' dashboard: show write requests broken down by request type. #10599
* [ENHANCEMENT] Dashboards: clarify when query-frontend and query-scheduler dashboard panels are expected to show no data. #10624
* [ENHANCEMENT] Alerts: Add warning alert `DistributorGcUsesTooMuchCpu`. #10641
* [ENHANCEMENT] Dashboards: Add "Federation-frontend" dashboard for GEM. #10697
* [BUGFIX] Dashboards: fix how we switch between classic and native histograms. #10018
* [BUGFIX] Alerts: Ignore cache errors performing `delete` operations since these are expected to fail when keys don't exist. #10287
* [BUGFIX] Dashboards: fix "Mimir / Rollout Progress" latency comparison when gateway is enabled. #10495
Expand Down
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ JSONNET_FMT := jsonnetfmt

# path to the mimir-mixin
MIXIN_PATH := operations/mimir-mixin
MIXIN_OUT_PATH := operations/mimir-mixin-compiled
MIXIN_OUT_PATH ?= operations/mimir-mixin-compiled
MIXIN_OUT_PATH_SUFFIXES := "" "-baremetal" "-gem"

# path to the mimir jsonnet manifests
Expand Down Expand Up @@ -683,8 +683,8 @@ check-mixin-mimirtool-rules: build-mixin
go run ./cmd/mimirtool rules check --rule-dirs "$(MIXIN_OUT_PATH)$$suffix"; \
done

mixin-serve: ## Runs Grafana loading the mixin dashboards compiled at operations/mimir-mixin-compiled.
@./operations/mimir-mixin-tools/serve/run.sh
mixin-serve: ## Runs Grafana loading the mixin dashboards. Use MIXIN_OUT_PATH=operations/mimir-mixin-compiled-gem for GEM variant
@./operations/mimir-mixin-tools/serve/run.sh -p $(MIXIN_OUT_PATH)

mixin-screenshots: ## Generates mixin dashboards screenshots.
@find $(DOC_SOURCES_PATH)/manage/monitor-grafana-mimir/dashboards -name '*.png' -delete
Expand Down
Loading
Loading