-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin: add Federation-frontend dashboard #10697
Merged
dimitarvdimitrov
merged 5 commits into
main
from
dimitar/mixin/add-gem-federation-frontend-dashboard
Feb 20, 2025
Merged
mixin: add Federation-frontend dashboard #10697
dimitarvdimitrov
merged 5 commits into
main
from
dimitar/mixin/add-gem-federation-frontend-dashboard
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
charleskorn
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (I assume the dashboard definition here is the same as what we previously had in the closed-source repo.)
a656f81
to
da345a4
Compare
Base automatically changed from
dimitar/mixin/add-gem-flavoured-compiled-mixin
to
main
February 20, 2025 08:16
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
da345a4
to
778aad2
Compare
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Add FF WIP Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix query panels Signed-off-by: Dimitar Dimitrov <[email protected]> * Allow running mixin-serve for different mixins Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove comments Signed-off-by: Dimitar Dimitrov <[email protected]> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]>
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Add FF WIP Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix query panels Signed-off-by: Dimitar Dimitrov <[email protected]> * Allow running mixin-serve for different mixins Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove comments Signed-off-by: Dimitar Dimitrov <[email protected]> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is based on #10690 just so that I could compile the mixin. The changes aren't related.
This PR also makes it possible to run
make serve-mixin
for arbitrary compiled dashboardsChecklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.