Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: add Federation-frontend dashboard #10697

Merged

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

This is based on #10690 just so that I could compile the mixin. The changes aren't related.

This PR also makes it possible to run make serve-mixin for arbitrary compiled dashboards

Screenshot 2025-02-19 at 19 35 57 Screenshot 2025-02-19 at 19 36 03

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I assume the dashboard definition here is the same as what we previously had in the closed-source repo.)

@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mixin/add-gem-federation-frontend-dashboard branch from a656f81 to da345a4 Compare February 20, 2025 07:55
Base automatically changed from dimitar/mixin/add-gem-flavoured-compiled-mixin to main February 20, 2025 08:16
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mixin/add-gem-federation-frontend-dashboard branch from da345a4 to 778aad2 Compare February 20, 2025 08:19
@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) February 20, 2025 08:20
@dimitarvdimitrov dimitarvdimitrov merged commit d860192 into main Feb 20, 2025
28 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/mixin/add-gem-federation-frontend-dashboard branch February 20, 2025 08:32
ying-jeanne pushed a commit that referenced this pull request Feb 20, 2025
* Add FF WIP

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Fix query panels

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Allow running mixin-serve for different mixins

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Remove comments

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Add CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
ying-jeanne pushed a commit that referenced this pull request Feb 20, 2025
* Add FF WIP

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Fix query panels

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Allow running mixin-serve for different mixins

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Remove comments

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Add CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants