Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestCase] azurerm_service_fabric_managed_cluster - add tags #27367

Closed
wants to merge 3 commits into from

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Sep 12, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Recently test cases related with Service Fabric Managed Cluster failed on Teamcity Daily Run. After I checked, I found service API would automatically add the tag "SFRP.DisableDefaultOutboundAccess" so that test case failed. Service team confirmed that it's a temporary tag ( will be removed at mid/late next year) for retiring default outbound access. Here is the official Azure announcement on this Default outbound access for VMs in Azure will be retired— transition to a new method of internet access | Azure updates | Microsoft Azure. So we have to add the tag to the request during creation as workaround.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • [TestCase] azurerm_service_fabric_managed_cluster - add tags

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@stephybun
Copy link
Member

@neil-yechenwei thanks for providing the context and links in the description! Since this is a temporary tag we've decided to workaround this by ignoring the tag in the resource in #27413.

@stephybun stephybun closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants