Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_service_fabric_managed_cluster - hide a tag that azure is adding outside of Terraform #27413

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

mbfrahry
Copy link
Member

azurerm_service_fabric_managed_cluster tests are currently failing because of a tag that Azure is adding outside of Terraform. SFRP.DisableDefaultOutboundAccess": "true".

I'm of the mind that we can just hide it away for now. We could add it back as it's own attribute if there is value there though.

@stephybun
Copy link
Member

@mbfrahry see #27367

@mbfrahry mbfrahry requested review from katbyte and a team as code owners November 1, 2024 22:52
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry LGTM 👍

@stephybun stephybun merged commit e4e45a1 into main Nov 4, 2024
29 of 30 checks passed
@stephybun stephybun deleted the t-service-fabric-managed-clusters branch November 4, 2024 07:42
@github-actions github-actions bot added this to the v4.9.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants