Update manifest.yml to use tag rather than sha #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Sep 5, 2024
| @@ -99,7 +99,7 @@ jobs: | |||
| path: /tmp/heroku-${{ matrix.stack-version }}* | |||
| - name: Upload heroku runtime images to staging | |||
| run: | | |||
| bin/upload-runtime-images.sh ${{ matrix.stack-version }} ${{ github.sha }} | |||
| bin/upload-runtime-images.sh ${{ matrix.stack-version }} ${{ github.ref_name }} | |||
There was a problem hiding this comment.
The ctc-check job also uses github.sha (when iirc that used the tag before too). Should that be switched back to the tag too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current iteration of https://s3.amazonaws.com/heroku_stacks_production/manifest.yml.signed currently includes entries with git shas like this:
Prior to #318, git tags were used instead. e.g.:
This PR updates the CI action to use git tags, as before.