Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest.yml to use tag rather than sha #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update manifest.yml to use tag rather than sha #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
path: /tmp/heroku-${{ matrix.stack-version }}*
- name: Upload heroku runtime images to staging
run: |
bin/upload-runtime-images.sh ${{ matrix.stack-version }} ${{ github.sha }}
bin/upload-runtime-images.sh ${{ matrix.stack-version }} ${{ github.ref_name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ctc-check job also uses github.sha (when iirc that used the tag before too). Should that be switched back to the tag too?


publish-images:
if: github.ref_name == 'main' || github.ref_type == 'tag'
Expand Down