Specify linux/amd64 architecture explicitly in Docker Makefile tasks
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when any of the Docker related `Makefile` targets are invoked from a machine that is not using the AMD64 (x86-64) architecture (such as a machine using the Apple M1), it emits the following warning: ``` WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested ``` In addition, were the `heroku/heroku:*` images ever to support ARM64 (see heroku/base-images#194), relying on an implicit platform value would mean the runtime generation tasks would silently start to generate binaries for a different architecture. To prevent this warning, and prevent such surprises with binary generation, the platform is now specified explicitly using `--platform`. GUS-W-10884947.
dzuelke
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when any of the Docker related
Makefiletargets are invoked from a machine that is not using the AMD64 (x86-64) architecture (such as a machine using the Apple M1), it emits the following warning:In addition, were the
heroku/heroku:*images ever to support ARM64 (see heroku/base-images#194), relying on an implicit platform value would mean the runtime generation tasks would silently start to generate binaries for a different architecture.To prevent this warning and the above potential surprises with binary generation, the platform is now specified explicitly using
--platform.GUS-W-10884947.