Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify linux/amd64 architecture explicitly in Docker Makefile tasks #1297

Merged
merged 1 commit into from
Mar 23, 2022

Commits on Mar 23, 2022

  1. Specify Docker architecture explicitly in Makefile tasks

    Currently when any of the Docker related `Makefile` targets are invoked
    from a machine that is not using the AMD64 (x86-64) architecture (such
    as a machine using the Apple M1), it emits the following warning:
    
    ```
    WARNING: The requested image's platform (linux/amd64) does not match the
    detected host platform (linux/arm64/v8) and no specific platform was requested
    ```
    
    In addition, were the `heroku/heroku:*` images ever to support ARM64
    (see heroku/base-images#194), relying on an
    implicit platform value would mean the runtime generation tasks would
    silently start to generate binaries for a different architecture.
    
    To prevent this warning, and prevent such surprises with binary
    generation, the platform is now specified explicitly using `--platform`.
    
    GUS-W-10884947.
    edmorley committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    daf2c41 View commit details
    Browse the repository at this point in the history