feat(ssg): make it simple #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25613d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yusukebe
reviewed
Feb 16, 2024
packages/ssg/src/ssg.ts
Outdated
| source: data, | ||
| }) | ||
| }, | ||
| async mkdir() {}, |
There was a problem hiding this comment.
This line throws the eslint error:
How about writing the following to avoid it?
async mkdir() {
return
},There was a problem hiding this comment.
fixed! 4e24768 (#80)
yusukebe
reviewed
Feb 16, 2024
| @@ -45,31 +64,27 @@ export const ssgBuild = (options?: SSGOptions): Plugin => { | |||
| throw new Error(`Failed to find a named export "default" from ${entry}`) | |||
| } | |||
|
|
|||
| console.log(`Build files into temp directory: ${tempDir}`) | |||
| const outDir = config.build.outDir | |||
There was a problem hiding this comment.
Using outDir from Vite's config is good!
|
Thanks! @berlysia Great PR! I've left the comments; check them, and could you run |
|
Thank you! I'll merge this now and release the new version! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on research in honojs/honox#48
before: Use Vite to build the toSSG generated code. This means that it was built twice.
after: Generate a page with toSSG. That's it.