Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node12 compilation errors and get it working on centos 7 #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jjhoughton
Copy link

This PR:

  • fixes the compilation errors when compling with node12
  • If you are using linux and are compiling with node10 or above it'll use a prebuilt version of libldap and liblber that is compiled against the same version of openssl that node uses. As i've removed the dependancy on openldap i've included the headers in this pr so you no longer have to have openldap-devel installed. Notice i've commited liblber.a and libldap.a. They where compiled like this jjhoughton/napi-ldap@14abe78 See the commit message for more details
commit 37dbb2043fbab457d1a4aba01fe13820f0d75627 (HEAD, ripjar/fix-node12-compilation-errors)
Author: Joshua Houghton <[email protected]>
Date:   Fri Aug 14 16:44:03 2020 +0000

    Remove dependancy on libldap on linux

    The issue is that centos 7 has the old version of openssl installed
    and node12 is compiled with the new version of openssl. As libldap
    on centos 7 is compiled against the old version of openssl we get a
    segfault if we compile against the system version of libldap.

    Thereofore I've built a version of libldap against the correct
    version of openssl which i then statically link against my node
    library. I've also included the ldap header file so i can remove
    the dependancy on openldap-devel.

    Signed-off-by: Joshua Houghton <[email protected]>

moxonj and others added 3 commits August 16, 2020 11:03
The issue is that centos 7 has the old version of openssl installed
and node12 is compiled with the new version of openssl. As libldap
on centos 7 is compiled against the old version of openssl we get a
segfault if we compile against the system version of libldap.

Thereofore I've built a version of libldap against the correct
version of openssl which i then statically link against my node
library. I've also included the ldap header file so i can remove
the dependancy on openldap-devel.

Signed-off-by: Joshua Houghton <[email protected]>
@jjhoughton jjhoughton changed the title Fix node12 compilation errors Fix node12 compilation errors and get it working on centos 7 Aug 16, 2020
@jjhoughton
Copy link
Author

I've also got this to work with mac and centos6 with node10 and node12 ripjar#1 i'll port the changes across if you're interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants