Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-2156: Remove eslint-plugin #1507

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

avivtur
Copy link
Collaborator

@avivtur avivtur commented Mar 3, 2025

📝 Links

References: https://issues.redhat.com/browse/MTV-2156

part of UI tech debts: https://issues.redhat.com/browse/MTV-1885

📝 Description

Removing eslint-plugin to allow easier maintenance of the code base. removing also config file from packages that were only pointing to the same config, the config is now derived from the root configs with no need for extra files

🎥 Demo

Please add a video or an image of the behavior/changes

📝 CC://

@tag as needed

@avivtur avivtur force-pushed the remove-eslint-plugin branch from bfc87b4 to f50e6ea Compare March 3, 2025 18:01
avivtur added 3 commits March 3, 2025 20:23
Signed-off-by: Aviv Turgeman <[email protected]>
Signed-off-by: Aviv Turgeman <[email protected]>
Signed-off-by: Aviv Turgeman <[email protected]>
@avivtur avivtur force-pushed the remove-eslint-plugin branch from efeccf3 to 73888f2 Compare March 3, 2025 18:24
Copy link

sonarqubecloud bot commented Mar 3, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.26%. Comparing base (13484d0) to head (73888f2).
Report is 315 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   36.81%   36.26%   -0.56%     
==========================================
  Files         158      157       -1     
  Lines        2548     2573      +25     
  Branches      599      604       +5     
==========================================
- Hits          938      933       -5     
- Misses       1428     1454      +26     
- Partials      182      186       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants