Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Release v0.89.1 #1611

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[main] Release v0.89.1 #1611

merged 1 commit into from
Sep 21, 2023

Conversation

kubevirt-bot
Copy link
Collaborator

What this PR does / why we need it:
Release v0.89.1

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oshoval
Copy link
Collaborator

oshoval commented Sep 21, 2023

/cc @AlonaKaplan
/cc @RamLavi

patch release from main branch so HCO will include kubevirt/kubesecondarydns#61

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@RamLavi
Copy link
Collaborator

RamLavi commented Sep 21, 2023

/approve

@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@oshoval
Copy link
Collaborator

oshoval commented Sep 21, 2023

the famous #1585
hope we can remove 0.69.0 soon

/override pull-e2e-cluster-network-addons-operator-lifecycle-k8s

@kubevirt-bot
Copy link
Collaborator Author

@oshoval: Overrode contexts on behalf of oshoval: pull-e2e-cluster-network-addons-operator-lifecycle-k8s

In response to this:

the famous #1585
hope we can remove 0.69.0 soon

/override pull-e2e-cluster-network-addons-operator-lifecycle-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 7e2c60d into main Sep 21, 2023
2 checks passed
RamLavi added a commit that referenced this pull request Nov 8, 2023
@RamLavi
Revert "[main] Release v0.89.1 (#1611)"
41d2539 
This reverts commit 7e2c60d.
@RamLavi RamLavi mentioned this pull request Nov 8, 2023
Merged
RamLavi added a commit that referenced this pull request Nov 8, 2023
@RamLavi
Revert "[main] Release v0.89.1 (#1611)"
81dea95 
This reverts commit 7e2c60d.

Signed-off-by: Ram Lavi <[email protected]>
RamLavi added a commit that referenced this pull request Nov 8, 2023
@RamLavi
Revert "[main] Release v0.89.1 (#1611)"
581ee41 
This reverts commit 7e2c60d.
It also stops the /automation/release.sh script from running so that the
release revert won't cause false image pushes.

Signed-off-by: Ram Lavi <[email protected]>
RamLavi added a commit that referenced this pull request Nov 8, 2023
@RamLavi
Revert "[main] Release v0.89.1 (#1611)"
5073af7 
This reverts commit 7e2c60d.

Signed-off-by: Ram Lavi <[email protected]>
RamLavi added a commit that referenced this pull request Nov 8, 2023
@RamLavi
Revert "[main] Release v0.89.1 (#1611)"
64b923b 
This reverts commit 7e2c60d.

Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot pushed a commit that referenced this pull request Nov 8, 2023
@RamLavi
Revert "[main] Release v0.89.1 (#1611)" (#1691)
dc412b1 
This reverts commit 7e2c60d.

Signed-off-by: Ram Lavi <[email protected]>
@oshoval oshoval mentioned this pull request Nov 12, 2023
Open
@oshoval
Copy link
Collaborator

oshoval commented Apr 15, 2024

note: keep in mind that this PR was created wrong (and later we reverted the impacts)
#1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval approved these changes

@alonSadan alonSadan Awaiting requested review from alonSadan

@RamLavi RamLavi Awaiting requested review from RamLavi

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

Assignees

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubevirt-bot @oshoval @RamLavi