Add rust to eve-alpine

[deitch]

Adds rust from edge to eve-alpine, following the instructions in ALPINE.md:

1. Found latest tag for eve-alpine from Docker Hub to be fbf39533415522ac124a2da9a695fda686adedc3
2. Changed the FROM line in pkg/alpine/Dockerfile to use that tag
3. Added rust to pkg/alpine/mirrors/edge
4. Committed and pushed changes
5. Opened this PR 😁

Offhand I do not recall if our pipeline automatically pushes out the updated lfedge/eve-alpine once built.

[deitch]

This failure is the oddest thing. I didn't change anything off of master except those 2 files, but go test -race is failing with something related to NIReconciler?

[deitch]

Also, there was a bug in build-cache.sh where it was not catching edge and calling it "vedge". This is fixed as well. Thanks to @jsfakian for finding it.

[deitch]

OK, now tests pass.

[rucoder]

@deitch what rust version is that? According to best practices the right way to install rust is ti use rustup. Rust package in OS distros serves only one purpose -- build some rust tools in that distro. If your rust project uses rust-toolchain.toml e.g.

[toolchain]
channel = "1.80.0"
# The supported toolchains used to build the project
targets = ["x86_64-unknown-linux-musl", "aarch64-unknown-linux-musl"]
# riscv target doesn't have a musl target yet and std is not available for it
#, "riscv64gc-unknown-linux-gnu"]
profile = "minimal"

I'm pretty sure it will fail to build. Besides, rust toolchain is a cross toolchain. does Alpine package contains all the targets ?

[deitch]

@rucoder that is a good question. The current version is 1.80.1. This is how we install go as well (see the peer file mirrors/edge/community. I believe @famleebob is working on switching our alpine base to 3.20 from 3.16, at which point we can move it all into the main mirrors/3.20/.

Rust package in OS distros serves only one purpose -- build some rust tools in that distro.

Mostly (not entirely) this is how we get tools available. Right now, we only have it in one place, the incoming #4055 interactive-installer, but more are coming. To get it to work, @jsfakian had to install it manually in his package, which is problematic.

There are 2 distinct questions going on here:

1. How can we make rust available to all downstream packages, the same way they can access go or python, and do it quickly to unblock Added interactive installer package in pkg/installer #4055. This is our current best answer to that.
2. Is there a better way to make tools like rust (or go, for that matter) available, rather than Alpine's OS package? There might be, I have done some things like that before in our design.

Your 2 is asking a very valid question, which affects more than just rust. I don't want to slow him down, though. We should get this in, get him unblocked, and if we want to change how we install these tools, let's have that discussion separately.

[rucoder]

@rucoder that is a good question. The current version is 1.80.1. This is how we install go as well (see the peer file mirrors/edge/community. I believe @famleebob is working on switching our alpine base to 3.20 from 3.16, at which point we can move it all into the main mirrors/3.20/.

Rust package in OS distros serves only one purpose -- build some rust tools in that distro.

Mostly (not entirely) this is how we get tools available. Right now, we only have it in one place, the incoming #4055 interactive-installer, but more are coming. To get it to work, @jsfakian had to install it manually in his package, which is problematic.

There are 2 distinct questions going on here:

1. How can we make rust available to all downstream packages, the same way they can access go or python, and do it quickly to unblock [Added interactive installer package in pkg/installer #4055](https://github.com/lf-edge/eve/pull/4055). This is our current best answer to that.

2. Is there a better way to make tools like rust (or go, for that matter) available, rather than Alpine's OS package? There might be, I have done some things like that before in our design.

Your 2 is asking a very valid question, which affects more than just rust. I don't want to slow him down, though. We should get this in, get him unblocked, and if we want to change how we install these tools, let's have that discussion separately.

@deitch I updated my comment with more questions, did not expect you to answer so fast :)

[rucoder]

@deitch I would just create a separate container e.g. eve-rust, base it on alpine and install all the tools using rustup + cargo-chef . It will simplify later rust version updates without touching eve-alpine.

[rucoder]

@deitch take a look how I build rust code in a container now. It allows caching the dependencie. the first part of the Dockerfile may be used for eve-rust https://github.com/rucoder/eve/blob/rucoder/eve-mon/pkg/monitor/Dockerfile

[eriknordmark]

Shouldn't we update all of the FROM eve-alpine lines to use the same tag?

[deitch]

If we go ahead with this. I'm planning on leaving this open, as the eve-rust approach is better. Once that is in, I'll close this.

[deitch]

Converted to a draft, since we are hoping to use github.com/lf-edge/eve-rust as an image.

[rucoder]

to whom it may concern: the repo eve-rust is created https://github.com/lf-edge/eve-rust/

[rucoder]

@deitch I guess we can close this one

[deitch]

Agreed. I was waiting for everyone to be inline with the eve-rust approach, but now we can close this one.