Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust to eve-alpine #4145

Closed
wants to merge 1 commit into from
Closed

Add rust to eve-alpine #4145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# image was bootstraped using FROM lfedge/eve-alpine-base:fad44e3702708a8d044663a20fd98d933dddb41e AS cache
# to update please see https://github.com/lf-edge/eve/blob/master/docs/BUILD.md#how-to-update-eve-alpine-package
FROM lfedge/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726 AS cache
FROM lfedge/eve-alpine:fbf39533415522ac124a2da9a695fda686adedc3 AS cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update all of the FROM eve-alpine lines to use the same tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go ahead with this. I'm planning on leaving this open, as the eve-rust approach is better. Once that is in, I'll close this.


ARG ALPINE_VERSION=3.16
# this is only needed once, when this package
Expand Down
2 changes: 1 addition & 1 deletion pkg/alpine/build-cache.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ bail() {

ALPINE_VERSION=$1

if [ "$ALPINE_VERSION" != "edge" ]; then
if [ "${ALPINE_VERSION#edge}" = "$ALPINE_VERSION" ]; then
ALPINE_VERSION=v$1
fi

Expand Down
2 changes: 2 additions & 0 deletions pkg/alpine/mirrors/edge/main
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rust
cargo
Loading